Repository navigation
Remove stale expected-failure markers from documentation checks - #721
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two documentation checks still carry strict expected-failure markers even though their underlying defects were fixed in
be9745b8(#712). This makes master lint fail with twoXPASS(strict)results.Remove those two
@known_defectdecorators and their unused import. Keep both assertions and test names unchanged, so the checks now act as ordinary regressions and still fail if either documentation defect returns. Update the module description and add the required changelog fragment. The shared known-defect helper, strictness, runner settings, SDK code, dependencies and CI gates are unchanged.Validation under the repository contributor guide and shared TDD policy:
XPASS(strict)using the normal runner.--runxfailrun: both original assertions passed; the documentation diff in docs: fix changelog date, SUPPORT typo, and document the full extra #712 independently confirms the fixes. This diagnostic option is not used for final validation.pytest -q test/staticin the locked doc/lint environment: 66 passed, with no skips or expected failures.uv lock --check, andgit diff --checkpassed.This corrects stale expectations using the existing tests; no new production behavior or artificial failing test was introduced. Both original assertions remain intact.
Live tests and bucket cleanup remain disabled:
B2_LIVE_TESTS_ENABLED=false, and the existing draft/opt-in gates are unchanged. Snyk is excluded as requested. Hosted GitHub Actions run 44961837233 passed on exact heada76eb5d27e16e21fc5bae40d353f5634bb7da208: 24 jobs passed, the cleanup job was skipped with zero steps executed, and all 21 SDK/CLI live-test steps were skipped. An AST comparison against the base confirms all test function bodies are unchanged. No private reports or finding-level corpus data are uploaded.Related: https://github.com/backblaze-labs/quality-keeper/issues/612 — keep the umbrella open.