Skip to content

Remove stale expected-failure markers from documentation checks - #721

Merged
sophiecarreras merged 1 commit into
masterfrom
codex/612-stale-doc-xfails
Nov 21, 2026
Merged

sophiecarreras merged 1 commit into
masterfrom
codex/612-stale-doc-xfails

Conversation

@sophiecarreras

@sophiecarreras sophiecarreras commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Two documentation checks still carry strict expected-failure markers even though their underlying defects were fixed in be9745b8 (#712). This makes master lint fail with two XPASS(strict) results.

Remove those two @known_defect decorators and their unused import. Keep both assertions and test names unchanged, so the checks now act as ordinary regressions and still fail if either documentation defect returns. Update the module description and add the required changelog fragment. The shared known-defect helper, strictness, runner settings, SDK code, dependencies and CI gates are unchanged.

Validation under the repository contributor guide and shared TDD policy:

  • Before editing, the two selected tests failed with XPASS(strict) using the normal runner.
  • Diagnostic --runxfail run: both original assertions passed; the documentation diff in docs: fix changelog date, SUPPORT typo, and document the full extra #712 independently confirms the fixes. This diagnostic option is not used for final validation.
  • After editing, the same normal test command: 2 passed.
  • Full pytest -q test/static in the locked doc/lint environment: 66 passed, with no skips or expected failures.
  • SDK-wide Ruff check, changed-file format check, license check, actionlint, CI-pinned uv lock --check, and git diff --check passed.

This corrects stale expectations using the existing tests; no new production behavior or artificial failing test was introduced. Both original assertions remain intact.

Live tests and bucket cleanup remain disabled: B2_LIVE_TESTS_ENABLED=false, and the existing draft/opt-in gates are unchanged. Snyk is excluded as requested. Hosted GitHub Actions run 44961837233 passed on exact head a76eb5d27e16e21fc5bae40d353f5634bb7da208: 24 jobs passed, the cleanup job was skipped with zero steps executed, and all 21 SDK/CLI live-test steps were skipped. An AST comparison against the base confirms all test function bodies are unchanged. No private reports or finding-level corpus data are uploaded.

Related: https://github.com/backblaze-labs/quality-keeper/issues/612 — keep the umbrella open.

@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@sophiecarreras
sophiecarreras marked this pull request as ready for review November 21, 2026 23:43
@sophiecarreras
sophiecarreras merged commit 23f39d6 into master Nov 21, 2026
28 checks passed
@sophiecarreras
sophiecarreras deleted the codex/612-stale-doc-xfails branch November 21, 2026 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant